Skip to content

Commit

Permalink
fix(controller): use the renamed API group for incubator package (#968)
Browse files Browse the repository at this point in the history
Aligns the API group name for KongServiceFacade RBAC rules so it matches after 
the rename Kong/kubernetes-ingress-controller#5302. Releases a kong/kong 2.33.1 patch.
  • Loading branch information
czeslavo authored Dec 7, 2023
1 parent 399604c commit f4246a8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
9 changes: 9 additions & 0 deletions charts/kong/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

## 2.33.1

### Fixed

* Use changed `incubator.ingress-controller.konghq.com` API group name in `KongServiceFacade`
RBAC rules. Refer to [KIC#5302](https://github.com/Kong/kubernetes-ingress-controller/pull/5302)
for rename reasoning.
[#968](https://github.com/Kong/charts/pull/968)

## 2.33.0

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion charts/kong/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ maintainers:
name: kong
sources:
- https://github.com/Kong/charts/tree/main/charts/kong
version: 2.33.0
version: 2.33.1
appVersion: "3.5"
dependencies:
- name: postgresql
Expand Down
4 changes: 2 additions & 2 deletions charts/kong/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -1266,15 +1266,15 @@ resource roles into their separate templates.
{{- if and (semverCompare ">= 3.1.0" (include "kong.effectiveVersion" .Values.ingressController.image))
(contains (print .Values.ingressController.env.feature_gates) "KongServiceFacade=true") }}
- apiGroups:
- incubator.konghq.com
- incubator.ingress-controller.konghq.com
resources:
- kongservicefacades
verbs:
- get
- list
- watch
- apiGroups:
- incubator.konghq.com
- incubator.ingress-controller.konghq.com
resources:
- kongservicefacades/status
verbs:
Expand Down

0 comments on commit f4246a8

Please sign in to comment.