chore: change pattern of autogenerated `ValidatingWebhookConfiguratio…

…n` name (#1211)
Kong · Jan 7, 2025 · 7646b3a · 7646b3a
1 parent a59fcf1
commit 7646b3a
Show file tree

Hide file tree

Showing 19 changed files with 27 additions and 35 deletions.
diff --git a/charts/kong/CHANGELOG.md b/charts/kong/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## Unreleased
+
+### Changes
+
+* Autogenerated name of `ValidatingWebhookConfiguration` changed from
+  `<FULLNAME>-validations` to `<FULLNAME>-<CHART-INSTALLATION-NAMESPACE>-validations`
+  to avoid collisions in case of multiple installations.
+  [#1211](https://github.com/Kong/charts/pull/1211)
+
 ## 2.46.0
 
 ### Changes

diff --git a/charts/kong/ci/.chartsnap.yaml b/charts/kong/ci/.chartsnap.yaml
@@ -21,7 +21,7 @@ dynamicFields:
       - /data/tls.key
   - apiVersion: admissionregistration.k8s.io/v1
     kind: ValidatingWebhookConfiguration
-    name: chartsnap-kong-validations
+    name: chartsnap-kong-default-validations
     jsonPath:
       - /webhooks/0/clientConfig/caBundle
       - /webhooks/1/clientConfig/caBundle

diff --git a/charts/kong/ci/__snapshots__/admission-webhook-configuration.snap b/charts/kong/ci/__snapshots__/admission-webhook-configuration.snap
diff --git a/charts/kong/ci/__snapshots__/custom-entities-rbac-3.2-values.snap b/charts/kong/ci/__snapshots__/custom-entities-rbac-3.2-values.snap
diff --git a/charts/kong/ci/__snapshots__/custom-labels-values.snap b/charts/kong/ci/__snapshots__/custom-labels-values.snap
diff --git a/charts/kong/ci/__snapshots__/default-values.snap b/charts/kong/ci/__snapshots__/default-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-1-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-1-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-2-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-2-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-3-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-3-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-4-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-4-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-5-3.1-rbac-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-5-3.1-rbac-values.snap
diff --git a/charts/kong/ci/__snapshots__/kong-ingress-5-3.4-rbac-values.snap b/charts/kong/ci/__snapshots__/kong-ingress-5-3.4-rbac-values.snap
diff --git a/charts/kong/ci/__snapshots__/proxy-appprotocol-values.snap b/charts/kong/ci/__snapshots__/proxy-appprotocol-values.snap
diff --git a/charts/kong/ci/__snapshots__/service-account.snap b/charts/kong/ci/__snapshots__/service-account.snap
diff --git a/charts/kong/ci/__snapshots__/single-image-default-values.snap b/charts/kong/ci/__snapshots__/single-image-default-values.snap
diff --git a/charts/kong/ci/__snapshots__/test1-values.snap b/charts/kong/ci/__snapshots__/test1-values.snap
diff --git a/charts/kong/ci/__snapshots__/test2-values.snap b/charts/kong/ci/__snapshots__/test2-values.snap
diff --git a/charts/kong/ci/__snapshots__/test5-values.snap b/charts/kong/ci/__snapshots__/test5-values.snap
diff --git a/charts/kong/templates/admission-webhook.yaml b/charts/kong/templates/admission-webhook.yaml
@@ -30,8 +30,7 @@ apiVersion: admissionregistration.k8s.io/v1
 apiVersion: admissionregistration.k8s.io/v1beta1
 {{- end }}
 metadata:
-  name: {{ template "kong.fullname" . }}-validations
-  namespace: {{ template "kong.namespace" . }}
+  name: {{ template "kong.fullname" . }}-{{ template "kong.namespace" . }}-validations
   labels:
     {{- include "kong.metaLabels" . | nindent 4 }}
   {{- if .Values.ingressController.admissionWebhook.annotations }}