Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf(interpreter): improve ATC interprater's cache efficiency (#246)" #284

Merged
merged 2 commits into from
Dec 20, 2024

chore(*): bump to version 1.7.1

2ca63fa
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Revert "perf(interpreter): improve ATC interprater's cache efficiency (#246)" #284

chore(*): bump to version 1.7.1
2ca63fa
Select commit
Loading
Failed to load commit list.
GitHub Actions / Rust Clippy Report succeeded Dec 18, 2024 in 0s

Rust Clippy Report

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 146 in src/ffi/expression.rs

See this annotation in the file changed.

@github-actions github-actions / Rust Clippy Report

empty line after doc comment

warning: empty line after doc comment
   --> src/ffi/expression.rs:145:1
    |
145 | / /// - `errbuf_len` must be a valid pointer for reading and writing `size_of::<usize>()` bytes and properly aligned.
146 | |
    | |_
147 |   #[no_mangle]
148 | / pub unsafe extern "C" fn expression_validate(
149 | |     atc: *const u8,
150 | |     schema: &Schema,
151 | |     fields_buf: *mut u8,
...   |
156 | |     errbuf_len: *mut usize,
157 | | ) -> i64 {
    | |________- the comment documents this function
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = help: if the empty line is unintentional remove it

Check warning on line 160 in src/parser.rs

See this annotation in the file changed.

@github-actions github-actions / Rust Clippy Report

unneeded `return` statement

warning: unneeded `return` statement
   --> src/parser.rs:160:5
    |
160 |     return pair.as_str().chars().next().unwrap();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `-W clippy::needless-return` implied by `-W clippy::style`
    = help: to override `-W clippy::style` add `#[allow(clippy::needless_return)]`
help: remove `return`
    |
160 -     return pair.as_str().chars().next().unwrap();
160 +     pair.as_str().chars().next().unwrap()
    |

Check warning on line 19 in src/parser.rs

See this annotation in the file changed.

@github-actions github-actions / Rust Clippy Report

empty line after doc comment

warning: empty line after doc comment
  --> src/parser.rs:17:1
   |
17 | / /// cbindgen:ignore
18 | | // Bug: https://github.com/eqrion/cbindgen/issues/286
19 | |
   | |_
20 |   trait IntoParseResult<T> {
   |   ------------------------ the comment documents this trait
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
   = note: `-W clippy::empty-line-after-doc-comments` implied by `-W clippy::suspicious`
   = help: to override `-W clippy::suspicious` add `#[allow(clippy::empty_line_after_doc_comments)]`
   = help: if the empty line is unintentional remove it
help: if the doc comment should not document `IntoParseResult` comment it out
   |
17 | // /// cbindgen:ignore
   | ++