add bip44 derivation paths

[smk762]

Sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md
Need to merge this before merging KomodoPlatform/developer-docs#420 (comment)

@sergeyboyko0791 For coins like XXX-PLG20 should the MATIC derivation path be added (and same for other EVMs)?

And re: #512 (comment) what will happen with coins that lack this info?

[sergeyboyko0791]

Yes, it's better to add the derivation path for ERC20 tokens the same as for platform coins, because there is still a possibility to activate the ERC20 token with the legacy enable RPC. In that case the ERC20 token config is the only source for such info.

For coins like XXX-PLG20 should the MATIC derivation path be added (and same for other EVMs)?

[smk762]

Yes, it's better to add the derivation path for ERC20 tokens the same as for platform coins, because there is still a possibility to activate the ERC20 token with the legacy enable RPC. In that case the ERC20 token config is the only source for such info.

For coins like XXX-PLG20 should the MATIC derivation path be added (and same for other EVMs)?

Done. I've also updated a few tickers which did not have a protocol suffix (ref: #498)

Will handle Trezor name info in separate PR. This info is not available in a convenient form - the list at https://trezor.io/coins is incomplete - for example QTUM is not shown (and is not in source code of page) until explicitly searched for. I'll contact Satoshi Labs to see if they can provide a complete list in csv or json format.

[cipig]

if tickers are changed, they need to be changed in https://github.com/KomodoPlatform/coins/tree/master/api_ids too
or we should change the logic, so that we don't need to add USDT-BEP20 and USDT-PLG20 to the api_ids, but just USDT

[smk762]

if tickers are changed, they need to be changed in https://github.com/KomodoPlatform/coins/tree/master/api_ids too or we should change the logic, so that we don't need to add USDT-BEP20 and USDT-PLG20 to the api_ids, but just USDT

I've updated the API json files, we can change logic in a different PR

[cipig]

that is the wrong coin, FJC is still FJC, the native coin, FJCB (next line) is now FJCB-BEP20, the BEP20 token

[sergeyboyko0791]

LGTM! One question - README.md contains 7. Trezor coin name (optional) topic, but trezor_coin field hasn't been added in this PR. Do you plan to add the field at the next PR?

[sergeyboyko0791]

Is path os now required the typo?

[smk762]

fixed, thanks

[smk762]

Will handle Trezor name info in separate PR. This info is not available in a convenient form - the list at https://trezor.io/coins is incomplete - for example QTUM is not shown (and is not in source code of page) until explicitly searched for. I'll contact Satoshi Labs to see if they can provide a complete list in csv or json format.

Will handle Trezor name info in separate PR. This info is not available in a convenient form - the list at https://trezor.io/coins is incomplete - for example QTUM is not shown (and is not in source code of page) until explicitly searched for. I've contacted Satoshi Labs to see if they can provide a complete list in csv or json format and am awaiting a response. If no reply soon, I'll add what I can from the default page link.

[SirSevenG]

lgtm