Reduce code duplication and clean up the Inovelli Converter

[rohankapoorcom]

In preparation for the new VZM30-SN, I spent some time cleaning up the existing converter, reducing duplication and moving as much as possible to use modern extends.

@InovelliUSA please review when you have some time.

The power / energy monitoring multipliers don't seem to be working currently (I commented on the specific line below).

[rohankapoorcom]

The min/max/change here doesn't seem to be respected (I'm not sure why). When I run a reconfigure, it's added with activePower min: 10, max: 65000, change: 5 and currentSummDelivered min: 10, max: 65000, change: 0.1 instead of what's provided here (matching the custom call below)

[InovelliUSA]

There are two reporting mechanisms in the device that can sometimes overlap. When we first created the device we took our configuration options from our Z-Wave switch not knowing (at the time) that Zigbee had its own built in energy / power reporting functionality. So, you can have different configurations in the exposes tab vs the reporting tab. If I could do it again, I would remove config options 17-19 and only used the built in Zigbee reporting. Anyway, I think that is why you may be seeing this. Try setting P17-19 to 0 and then test the reporting configuration.

[rohankapoorcom]

Sorry, I think my original message wasn't very clear.

I haven't changed any of the reporting parameters in the exposes tab. When the original code is running (see single commit diff: 44b0a9a), it explicitly sets (manually) the reporting to the min/max/change values as described on line 2025 and 2026. This leads to the following screenshot:

I switched the code to use the modern extend instead and passed it along the same min/max/change values as before. However, this doesn't seem to be taking affect. Leading to the following screenshot:

electricityMeter({
    current: false,
    voltage: false,
    power: {min: 15, max: 3600, change: 1},
    energy: {min: 15, max: 3600, change: 0},
})

I see duplication of the reporting calls (but with the correct values). Is that expected?

I think this is more of a question for @Koenkk.

[InovelliUSA]

Oh yeah, that isn't the question I thought it was and would be better answered by @Koenkk lol.

[Koenkk]

The change you pass here is divided by the divisor, so the change is in W, see

zigbee-herdsman-converters/src/lib/modernExtend.ts

Line 1911 in 6e3c0e3

change = property.change * (divisor / multiplier);

[Koenkk]

@InovelliUSA please review

[Koenkk]

Is this now ready for merge? (CC: @InovelliUSA )

[rohankapoorcom]

From my side, I think there's still one question here: #8402 (comment) for you @Koenkk.

I'll let Eric comment if he has other concerns.

[InovelliUSA]

Is this now ready for merge? (CC: @InovelliUSA )

Other than the question mentioned #8402 , I am ok with this merge.

[rohankapoorcom]

@Koenkk are you good to merge this? I'd like to open the next PR (starting from this one) adding the new device (VZM30-SN).

Thanks!

[Koenkk]

@rohankapoorcom yes, could you rebase it?

[rohankapoorcom]

Rebased @Koenkk

[Koenkk]

Thanks!