Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor keyboard input fixes #847

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

samhocevar
Copy link
Contributor

This PR tries to improve consistency across desktop platforms:

  • autorepeated keys on Windows (already works on Linux and OS X).
  • backspace triggers kinc_internal_keyboard_trigger_key_press() on Windows.
  • backspace, return, and tab trigger kinc_internal_keyboard_trigger_key_press() on OS X.

@RobDangerous RobDangerous merged commit a67c9af into Kode:main Jan 28, 2024
19 checks passed
@RblSb
Copy link
Contributor

RblSb commented Jan 28, 2024

Isn't autorepeating should be disabled on all platforms and implemented by user? At least this is basic behavior for keydown, not sure if this change about keypress and what behavior for keypress is preferable

@samhocevar
Copy link
Contributor Author

The application can just ignore repeated keys if it wants to implement its own autorepeat mechanism, so nothing is lost.

Also, exposing repeated keys ensures that the autorepeat delay and rate are exactly what the user configured in their operating system. I think that’s a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants