Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulkan] Improve GPU selection on multi-GPU systems. #846

Merged

Conversation

Apprentice-Alchemist
Copy link
Contributor

Always select a GPU that can actually present a surface.

Fixes #844.

@bluesillybeard could you test this on your system and make sure this fix actually works?

Always select a GPU that can actually present a surface.
@RobDangerous RobDangerous merged commit 3080a06 into Kode:main Jan 28, 2024
19 checks passed
@bluesillybeard
Copy link
Contributor

Nope, same thing happens. But, I have some time to debug it, comparing the behavior in the VM (where it works) and my host system (where it doesn't). I'll reply again to this thread (and maybe create PR with a fix) if/when I find the disparity.

@RobDangerous
Copy link
Member

And another good hint from Mr Apprentice - run it with --debug, that also enabled Vulkan validation.

@Apprentice-Alchemist Apprentice-Alchemist deleted the bugfix/vulkan-gpu-selection branch November 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty example doesn't work on X11 + Vulkan
3 participants