Potential fix for memory leak when resizing a display when using the D3D12 backend #827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how render targets are acquired/created in the d3d12 backend to fix #810
I'm pretty sure the source of the memory leak was a double created render target in the original code.
First the render target was created using
CreateCommittedResource()
and then, at the end ofrender_target_init()
, therender_target->impl.renderTarget
ptr was overwritten by eitheror
This fix was only added after a visual inspection and has only been validated with the Input test. More thorough testing is definitely needed to validate correctness.