Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Wrong target language used for simplified Chinese #814

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

aarongerig
Copy link
Contributor

@aarongerig aarongerig commented Oct 7, 2024

Last week the translation file for simplified Chinese has been added through commit 92002cc

Unfortunately, it got assigned the wrong value for the target-language attribute. The Symfony XliffUtils helper class now complains when validating the schema.

Invalid resource provided: "/var/www/html/vendor/knplabs/knp-paginator-bundle/translations/KnpPaginatorBundle.zh_CN.xliff"; Errors: [ERROR 1824] Element '{urn:oasis:names:tc:xliff:document:1.2}file', attribute 'target-language': 'zh_CN' is not a valid value of the atomic type 'xs:language'.

See the following resources:

This PR fixes that circumstance by changing the value from zh_CN to zh-CN.

@aarongerig aarongerig mentioned this pull request Oct 7, 2024
@garak garak merged commit 1a00f88 into KnpLabs:master Oct 7, 2024
13 checks passed
@aarongerig aarongerig deleted the patch-1 branch October 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants