This repository has been archived by the owner on Sep 23, 2022. It is now read-only.
Do not block adding a repo only if it's name does not validate a too restrictive regex rule #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…restrictive regex rule
wysow
force-pushed
the
458-fully-support-valid-names-of-github-repositories
branch
from
983c9a6 to
67ea643
Compare
|
@KnpLabs/knp-team Someone can take a look at this? |
|
No test to update? |
|
lgtm |
|
@gquemener Yep sounds strange but didn't find test about repo name... And as we do not know the valid regex usid by Github, I'm not sure we should add one, what do you think? |
|
maybe you can add a test then ? |
|
@docteurklein even if we don't know about the valid regex?? |
|
just test that it behaves like you want it to behave. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #458