Explicitly depend on racc to fix specs for Ruby 3.3+

[mattbrictson]

On Ruby 3.3.0-preview3, knapsack's own specs fail:

$ ruby -v
ruby 3.3.0dev (2023-11-12 master 60e19a0b5f) [x86_64-darwin23]

$ bundle exec rspec spec
An error occurred while loading spec_helper. - Did you mean?
                    rspec ./spec/spec_helper.rb

Failure/Error: require 'spinach'

LoadError:
  cannot load such file -- racc/parser.rb

This is because in Ruby 3.3, the racc gem is no longer a default gem. This change is mentioned in the Ruby 3.3.0-preview2 release notes:

The following default gem is now bundled.
racc 1.7.1

Since knapsack's specs rely on the racc gem being present, this means that in Ruby 3.3 racc must be explicitly declared as a development dependency in the Gemfile.

This commit adds the racc dependency, conditionally based on the Ruby version. With this change, the specs now pass.

$ ruby -v
ruby 3.3.0dev (2023-11-12 master 60e19a0b5f) [x86_64-darwin23]

$ bundle exec rspec spec
...
Finished in 1.91 seconds (files took 0.42586 seconds to load)
210 examples, 0 failures

[ArturT]

Thanks for reporting this and proposing a fix.

Why not always require racc in gemspec, no matter the Ruby version? Would this break anything for older Ruby versions?

# knapsack.gemspec
spec.add_development_dependency 'racc', '>= 1.7.3'

I added this PR to our internal backlog to be prioritized.

[mattbrictson]

I was worried that the racc dependency would fail under the old versions in the CI matrix (2.3). I'll move it to the gemspec to see what happens.

[mattbrictson]

I tested using the ruby:2.3 Docker image and it looks like the gemspec approach works. We'll see for sure when the CI workflow is run.

[ArturT]

I approved the GitHub Actions workflow for your PR.

[mattbrictson]

@ArturT thanks! Tests are passing for all Ruby versions in CI.

[ArturT]

I'm trying to understand how urgent this PR is. Is the issue limited only to running knapsack tests locally with Ruby 3.3+?

Or have you experienced issues running your project's tests on your CI using Ruby 3.3+ and knapsack 4.0.0?

[mattbrictson]

This is not urgent at all. It is only applicable to running knapsack tests locally.

[3v0k4]

We officially archived Knapsack, you can read more about it in the README.

Thank you for caring and creating this PR.

I'm sorry we couldn't get this done for you.