Remove slow_test pytest marker
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Feb 20, 2024
tests/test_multipart.py
Outdated
| @@ -10,6 +10,7 @@ | |||
| from unittest.mock import Mock | |||
|
|
|||
| import yaml | |||
| from pytest import mark | |||
|
Actually, how slow are those tests? Do we need this marker or can we just remove it? |
|
They are not particularly slow less than ½ a second here and all the other tests are a couple of seconds combined, so I dont think that marker serves a real pupose atm. |
janusheide
changed the title
|
A small note, what currently makes the tests "slow" is generating the coverage report, without it running pytest is roughly 3x faster. |
That's normal. |
Kludex
changed the title
slow_test pytest marker
Kludex
approved these changes
Feb 20, 2024
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the warning emitted by pytest due to slow_test not being a registered mark.