Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squashed many small commit messages for documentation and matrix/ci i… #528

Merged
merged 0 commits into from
May 23, 2024

Conversation

KjellKod
Copy link
Owner

…mprovements

PULL REQUEST DESCRIPTION

ADD CONTENT HERE TO DESCRIBE THE PURPOSE OF THE PULL REQUEST

Formatting

  • I am following the formatting style of the existing codebase.

a clang-format configuration file is available in the root of g3log.

  • Use VSCode with clang-formatter or commandline:
    clang-format -i path_to_file
  • or recursive throughout the whole repo: find . -iname "*.hpp" -o -iname "*.cpp" | xargs clang-format -i

Testing

  • This new/modified code was covered by unit tests.
  • (insight) Was all tests written using TDD (Test Driven Development) style?
  • The CI (Windows, Linux, OSX) are working without issues.
  • Was new functionality documented?
  • The testing steps 1 - 2 below were followed

step 1

mkdir build; cd build; cmake -DADD_G3LOG_UNIT_TEST=ON ..

// linux/osx alternative, simply run: ./scripts/buildAndRunTests.sh

step 2: use one of these alternatives to run tests:

  • Cross-Platform: ctest
  • or ctest -V for verbose output
  • Linux: make test

Copy link
Owner Author

@KjellKod KjellKod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, and we will NOT merge this but force push after squash to master

@KjellKod KjellKod merged commit e3d85a5 into master May 23, 2024
9 checks passed
@KjellKod KjellKod deleted the pre_branch branch May 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant