Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning #515

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Versioning #515

merged 4 commits into from
Dec 7, 2023

Conversation

KjellKod
Copy link
Owner

@KjellKod KjellKod commented Dec 7, 2023

PULL REQUEST DESCRIPTION

I believe this should take care of https://github.com/KjellKod/g3log/issues

Formatting

  • I am following the formatting style of the existing codebase.

Testing

  • The CI (Windows, Linux, OSX) are working without issues.
  • Was new functionality documented?
  • The testing steps 1 - 2 below were followed

step 1

mkdir build; cd build; cmake -DADD_G3LOG_UNIT_TEST=ON ..

// linux/osx alternative, simply run: ./scripts/buildAndRunTests.sh

step 2: use one of these alternatives to run tests:

  • Cross-Platform: ctest
  • or ctest -V for verbose output
  • Linux: make test

@KjellKod KjellKod merged commit 5980182 into master Dec 7, 2023
8 checks passed
@KjellKod KjellKod deleted the versioning branch December 7, 2023 03:14
@KjellKod KjellKod mentioned this pull request Dec 7, 2023
Closed
@Porkepix Porkepix mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KjellKod