Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi volume #3133

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Multi volume #3133

wants to merge 11 commits into from

Commits on Sep 30, 2024

  1. chore: Remove broken computeBounds functions 

    These functions used a `getInput` method that doesn't exist
It is not a breaking change as these functions instantly crash when called
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3c69cfd View commit details
    Browse the repository at this point in the history

  2. chore: Remove error in the console when mapper has no input

    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6479847 View commit details
    Browse the repository at this point in the history

  3. refactor: Make computation of bounds clearer 

    The ImageSlice actor already used a more concise code.
Do the same for the base Actor and and Volume actor.
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7d17a76 View commit details
    Browse the repository at this point in the history

  4. refactor: Avoid code duplication by moving getBounds 

    The prop3D has three children that were redefining `getBounds` in the same way.
Move the definition of `getBounds` in the prop3D.
Update typescript accordingly.
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b252a1b View commit details
    Browse the repository at this point in the history

  5. refactor: Move constants from mapper to volume property

    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    16dbe29 View commit details
    Browse the repository at this point in the history

  6. refactor: Move VolumeMapper rendering properties in VolumeProperty 

    BREAKING CHANGE: Move vtkVolumeMapper's properties related to rendering in vtkVolumeProperty.
Add a clear error message for these widely used methods.
This is part of the MultiVolumeMapper feature.
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7d01b40 View commit details
    Browse the repository at this point in the history

  7. feat: Add multi property handling to the volume actor 

    This work is part of the MultiVolumeMapper feature
Fix the getVolumes function which didn't return an array
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e4645f3 View commit details
    Browse the repository at this point in the history

  8. refactor: Add multi volume handling to the core volume mapper

    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6aa2f0c View commit details
    Browse the repository at this point in the history

  9. refactor: Simplify getNeedToRebuildShaders in VolumeMapper 

    Instead of comparing a big state that take all actor properties into account,
compare the mtime of the actor as it takes properties into account
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cb878b0 View commit details
    Browse the repository at this point in the history

  10. refactor: Move functions out of the volumeMapper publicAPI

    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bb5cae7 View commit details
    Browse the repository at this point in the history

  11. feat: Multi volume 

    Support multiple images as input
Shader compilation is too long
Even longer on Windows + NVidia
Use clang-reformat for a uniform styling of shader
    @bruyeret
    bruyeret committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d99136e View commit details
    Browse the repository at this point in the history