Update index.d.ts #3107
Open
Update index.d.ts #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the norm method in vtkMath, its second parameter should be non-required. However, in ts, an error reporting situation occurs every time.
finetjul
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Please respect the semantic release naming scheme of VTK.js.
You can use npm run commit to format your commit messages.
daker
suggested changes
Jul 31, 2024
| @@ -311,7 +311,7 @@ export function cross(x: Vector3, y: Vector3, out: Vector3): Vector3; | |||
| * @param {Number[]} x | |||
| * @param {Number} n | |||
| */ | |||
| export function norm(x: number[], n: number): number; | |||
| export function norm(x: number[], n: number = 3): number; | |||
There was a problem hiding this comment.
export function norm(x: number[], n?: number): number;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the norm method in vtkMath, its second parameter should be non-required. However, in ts, an error reporting situation occurs every time.
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting