-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GLTFImporter): add GLTFImporter #2479
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hi @daker , Any progress there? |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @daker, I may start looking into it. Do you have a feel of how much more work needs to go into it? Do you think we can reformat/rebase and merge it in its current state, or would it be better to work on the same branch until X and Y are solved? If so, knowing what X and Y are would be great. Thanks for your hard work pushing vtk.js forward, Seb |
I have updated the description with a list of questions/features to be addressed. Basically the loader is able to parse the gltf with simple embedded resources like the box or colored box. As you can see on the images, there is something missing in the code to render those boxes correctly, @finetjul told me that faces/cells do not seem to be made of the right point ids, i am not good on this part. My idea is to have a simple SceneLoader that will act like this : I would suggest to work on a branch, once we have a basic SceneLoader with basic parsing and rendering then we can merge and iterate over with adding animations and extensions depending on what we have decided. |
Sounds good, thanks for the update. |
@jourdain I am back working on this, i made some very good progress, no animation, lights , cameras, skins, morph or extensions so far The ORM textures are slow to display since they are computed(using canvas) by extracting the channels from a the combined texture, this should be done by the GPU like in vtk c++ by providing a setORMTexture (FYI @martinken) screen-capture.2.webm |
0d01463
to
597eaae
Compare
@jourdain Pushed new update screen-capture.1.webmAnimations are not working well on webGL, not sure if it's my code or vtk.js and it's not working with webGPU at all, the lags are due to the recording. screen-capture.2.webm |
I may need to read it more carefully but it looks great! Should we try to get it merged or is it still in WIP? |
Yes we can merge it, I have added support for GLB and Draco loading using |
Wow, I read it all and it is not small! Good job and thanks for your contribution. |
I'll have a look |
i will address the comments and fix the GLB buffer loading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great contribution.
Here are some various comments.
- You may want to expose at least an high-level
.d.ts
file. - Can you please add an entry in the example Gallery (Documentation/content/docs/example/index.md)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6938b2d
to
8cac623
Compare
It's ready to be merged, |
d3275c1
to
bf8c870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b496d08
to
d9914fe
Compare
2cda0ce
to
4073c2e
Compare
@floryst i have rebased this branch also in case you want to merge it |
@floryst when do you plan to merge the PR ? |
@daker sorry, I missed this because of the default github PR sort order. I'll fix the conflict and get this merged. |
Not sure why it was removed from the queue while it has not conflicts |
I'll try again. |
@daker can you rebase on master? |
🎉 This PR is included in version 32.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
This PR adds initial support for GLTF 2.0 format
Results
Changes
PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting
Fixes: #210