feat(polydatacellnormals): compute cell normals #2436
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
closes #2434
Gives the option through
setComputeCellNormals
to compute the cell normals for polyData using thevtkPolyDataNormals
filter.Results
Changes
polyData.getCellData().getNormals().getData()
vtkPolyDataNormals
filter to compute the cell normals-> Question related to this: can you autogenerate TS-def files? Or should these be created manually?
PR and Code Checklist
npm run reformat
to have correctly formatted codeTODO
I was thinking it might make sense to either change the
publicAPI.vtkPolyDataNormalsExecute
to accept only one parameter, which would bevtkPolyData
.Or to merge
publicAPI.vtkPolyDataNormalsExecute
andpublicAPI.vtkPolyDataCellNormalsExecute
into one method, as there is quite some duplication in both?I don't know what would be preferred.
Update the example to switch between cell and vertex normals