Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor constructors #2409

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Refactor constructors #2409

wants to merge 36 commits into from

Commits on Jun 21, 2022

  1. refactor(fullscreenrenderwindow, dataarray, remoteview, macro): refac… 

    …tor constructors

Refactor of (some classes) constructors so that the setXXX() methods of coresponding properties are
called when the classes are instanciated (calling newInstance). In the macro.js newInstance()
function, the set() method is called in order that the setXXX() methods for each entry of
initialValues is called if such methods exist. This is in order that side effects of setters are
taken into account when creating new objects (for example through the call of modified()). Setters
of both default and initial values are called.
Refactor of DataArray and child classes. The method "setData" is called so that the parameters are
synchronised as it is not a setter of one property in itself but has that purpose. Warning : it
cannot be overwritten in child classes without possible issues of behavior when creating the object.
Tests have been added and updated.
A new test for macro protected properties have been added.

BREAKING CHANGE: If a custom handling is done on the initialValues in the extend function, the
changes made might be overwritten by the call of the set function in newInstace. If it is not what
is intended, those properties have to be removed from initialValues after custom processing. If a
setter of a property is called in the function creating an object (vtkObject(publicAPI, model)) such
call should be removed to avoid witnessing twice the same side effects.
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5aeba62 View commit details
    Browse the repository at this point in the history

  2. feat(testmacro): defaultValues have protected values named with under… 

    …score

defaultValues have to have protected values named with underscore to avoid having them to be moved
to protected
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    4f77c69 View commit details
    Browse the repository at this point in the history

  3. fix(hardwareselector, renderwindow): fix after refactor 

    Change to put properties in initialValues to call setters on them. Handle null or undefined in some
setters.
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a89d4da View commit details
    Browse the repository at this point in the history

  4. fix(actor2d): change constructor to call setters 

    call setters at instanciation. Modify also related classes
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ff88fd8 View commit details
    Browse the repository at this point in the history

  5. fix(abstractmapper): fix setClippingPlane at instanciation 

    fix setClippingPlane at instanciation. Handle [] as possible given planes.
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    787a134 View commit details
    Browse the repository at this point in the history

  6. fix(actor,actor2d): fix refactoring 

    fix
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    592e0e0 View commit details
    Browse the repository at this point in the history

  7. fix(hardwareselector, renderwindow): fix refactoring 

    change polydatamapper
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    f011c14 View commit details
    Browse the repository at this point in the history

  8. fix(polydatamapper2d): refactor constructor 

    call setters at instanciation
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b2d09ed View commit details
    Browse the repository at this point in the history

  9. fix(datasetattributes): refactor constructors 

    refactor DataSetAttributes constructor to call setters
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    27e181b View commit details
    Browse the repository at this point in the history

  10. fix(colortransferfunction): refactor constructor to call setters 

    update setActiveProperty of datasetattributes to handle indexes being given
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    c1f6ef6 View commit details
    Browse the repository at this point in the history

  11. refactor(fielddata): improvement of getArrayWithIndexFix 

    improvement of getArrayWithIndexFix
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b70c1c9 View commit details
    Browse the repository at this point in the history

  12. refactor(polydatamapper): put some values in default rather than set … 

    …them in constructor

put some values in default rather than set them in constructor
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ea47367 View commit details
    Browse the repository at this point in the history

  13. fix(renderwindow): fix 

    fix after refactoring
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    986dfc1 View commit details
    Browse the repository at this point in the history

  14. fix(abstractmapper): remove useless initialValues setting 

    remove useless initialValues setting
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0672218 View commit details
    Browse the repository at this point in the history

  15. refactor(filtersources): refactor constructors to call setters 

    call setters when creating the object
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    62ca1dd View commit details
    Browse the repository at this point in the history

  16. fix(renderwindow): fix after refactor 

    fix after refactor (remove tmp true in newinstance)
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    763e1cf View commit details
    Browse the repository at this point in the history

  17. refactor(tmp): temporary to only call setters for modified files 

    Temporary to only call setters for modified files
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d607ff7 View commit details
    Browse the repository at this point in the history

  18. fix(polydatamapper): fix refactoring 

    fix refactoring
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ea30a90 View commit details
    Browse the repository at this point in the history

  19. refactor(helper): refactor constructor to call setters 

    refactor constructor to call setters
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    141eb1f View commit details
    Browse the repository at this point in the history

  20. fix(testactor2d): remove .only( 

    remove .only
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    531eb9a View commit details
    Browse the repository at this point in the history

  21. refactor(volume, texture): refactor constructor to call setters 

    refactor constructor to call setters
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    01407f9 View commit details
    Browse the repository at this point in the history

  22. refactor(sources): refactoring constructors 

    some more sources refactoring
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    12c88ab View commit details
    Browse the repository at this point in the history

  23. test(points): add some tests for points 

    add some tests for points (similar to dataarray tests)
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    1bb1060 View commit details
    Browse the repository at this point in the history

  24. refactor(stringarray,variantarray,progresshandler,priorityqueue): ref… 

    …actor constructors

refactor constructors to call setters. Change setData to handle instanciation and setting
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9b571db View commit details
    Browse the repository at this point in the history

  25. fix(lookuptable): fix refactoring 

    fix refactoring (put table in defaultValues)
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    afb7f86 View commit details
    Browse the repository at this point in the history

  26. refactor(cell): refactor constructor to call setters 

    refactor constructor to call setters
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    562a185 View commit details
    Browse the repository at this point in the history

  27. docs(lookuptable, appendpolydata): document some implementation choices 

    document some implementation choices
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d2725c2 View commit details
    Browse the repository at this point in the history

  28. fix(lookuptable): fix previous commit 

    fix previous commit
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7824f27 View commit details
    Browse the repository at this point in the history

  29. fix(abstractmapper, selectionnode): fix refactoring 

    fix refactoring
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b14ebe2 View commit details
    Browse the repository at this point in the history

  30. refactor(triangle, line): refactor constructors 

    refactor constructors to call setters at instanciation
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ad468f2 View commit details
    Browse the repository at this point in the history

  31. fix(camera): fix refactoring 

    remove undesired checks and document some choices
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b74186e View commit details
    Browse the repository at this point in the history

  32. fix(camera): fix previous commit 

    fix previous commit
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d4def46 View commit details
    Browse the repository at this point in the history

  33. fix(coordinate, hardwareselector): fix refactoring 

    fix refactoring
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    df6db6f View commit details
    Browse the repository at this point in the history

  34. fix(datasetattributes, mapper): fix refactoring 

    coherence in choices + fix to have exact same behavior
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    114330e View commit details
    Browse the repository at this point in the history

  35. fix(renderer,viewnode,renderwindow,...): fix refactoring 

    coherence in choices
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    8fb9e8d View commit details
    Browse the repository at this point in the history

  36. refactor(remoteview): refactor constructor 

    refactor constructor to call setters at instanciation
    @joannacirillo
    joannacirillo committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7f15397 View commit details
    Browse the repository at this point in the history