-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Slice Explorer): adding inital version of the slice explorer #115
Conversation
Adding Slice Explorer -- the main module in the `explorers` directory -- a driver example using python in `examples` -- a jupyter notebook demo example
Before merging, we need to update slice explorer to handle more general time coordinates
For testing, I have a small data file and notebook. For some reason, github will not let me upload either of these files, nor a tgz. So I put them on data.kitware. You can get them at https://data.kitware.com/#user/55dcb06e8d777f6ddc3ff892/folder/6703f95cfb903c47575a91f9 |
I've updated the code to use
With the change above we should be able to use any date time format. I need to check this with dataset with datatime object for time coordinates. I'll test with the new files you've shared below
|
7ce7c23
to
e16f117
Compare
@jourdain Any idea why the CI could be failing? |
Install pre-commits - See https://github.com/Kitware/pan3d/blob/main/CONTRIBUTING.rst Then if you run black by hand, you need to have the same version as the one defined here |
Thanks for the helpful tip, that got the formatting problems resolved. |
Maybe not related, but one issue that you have is your JSON file for the preset is not getting bundled in your Python package. Also a possibility for mac is a dependency not being available? |
Making necessary code maintainance and readability changes Adding presets for diverging color maps Expand and collapse drawer to expand render area Adding support for varied datetime objects for time dimension Adding documentation fix(ci) : conditionally adding pykdtree w/o OpenMP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, Abhi. thanks.
Adding Slice Explorer
-- the main module in the
explorers
directory-- a driver example using python in
examples
-- a jupyter notebook demo example