Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slice Explorer): adding inital version of the slice explorer #115

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ayenpure
Copy link
Collaborator

Adding Slice Explorer
-- the main module in the explorers directory
-- a driver example using python in examples
-- a jupyter notebook demo example

Adding Slice Explorer
  -- the main module in the `explorers` directory
  -- a driver example using python in `examples`
  -- a jupyter notebook demo example
@ayenpure ayenpure marked this pull request as draft September 25, 2024 03:15
@ayenpure ayenpure self-assigned this Sep 25, 2024
pan3d/dataset_builder.py Outdated Show resolved Hide resolved
@johnkit
Copy link
Collaborator

johnkit commented Oct 7, 2024

Before merging, we need to update slice explorer to handle more general time coordinates

  1. Update the current logic from month to instead use the builder's time coordinate.
  2. Need to handle more than integer time coordinates. At a min, let's get slice explorer to at least recognize/support datetime64[ns]. Maybe we can use the same logic as dataset viewer.

For testing, I have a small data file and notebook. For some reason, github will not let me upload either of these files, nor a tgz. So I put them on data.kitware. You can get them at https://data.kitware.com/#user/55dcb06e8d777f6ddc3ff892/folder/6703f95cfb903c47575a91f9

@ayenpure
Copy link
Collaborator Author

ayenpure commented Oct 8, 2024

Before merging, we need to update slice explorer to handle more general time coordinates

  1. Update the current logic from month to instead use the builder's time coordinate.

I've updated the code to use builder.t so that we do not hard code any dimension names

  1. Need to handle more than integer time coordinates. At a min, let's get slice explorer to at least recognize/support datetime64[ns]. Maybe we can use the same logic as dataset viewer.

With the change above we should be able to use any date time format. I need to check this with dataset with datatime object for time coordinates. I'll test with the new files you've shared below

For testing, I have a small data file and notebook. For some reason, github will not let me upload either of these files, nor a tgz. So I put them on data.kitware. You can get them at https://data.kitware.com/#user/55dcb06e8d777f6ddc3ff892/folder/6703f95cfb903c47575a91f9

@ayenpure ayenpure force-pushed the explorers branch 9 times, most recently from 7ce7c23 to e16f117 Compare October 9, 2024 21:49
@ayenpure
Copy link
Collaborator Author

ayenpure commented Oct 9, 2024

@jourdain Any idea why the CI could be failing?
I am at a loss as black locally does not report any changes for me but is failing pre-commit and for the MacOS tests something is weird as they pass for Linux and Windows

@jourdain
Copy link
Collaborator

jourdain commented Oct 9, 2024

Install pre-commits - See https://github.com/Kitware/pan3d/blob/main/CONTRIBUTING.rst

Then if you run black by hand, you need to have the same version as the one defined here

@ayenpure
Copy link
Collaborator Author

Install pre-commits - See https://github.com/Kitware/pan3d/blob/main/CONTRIBUTING.rst

Then if you run black by hand, you need to have the same version as the one defined here

Thanks for the helpful tip, that got the formatting problems resolved.
Any idea on how to tackle the MacOS failures? Locally they seem to work without problem

@jourdain
Copy link
Collaborator

Maybe not related, but one issue that you have is your JSON file for the preset is not getting bundled in your Python package.
You need to edit https://github.com/Kitware/pan3d/blob/main/pyproject.toml#L80-L83

Also a possibility for mac is a dependency not being available?

  Making necessary code maintainance and readability changes
  Adding presets for diverging color maps
  Expand and collapse drawer to expand render area
  Adding support for varied datetime objects for time dimension
  Adding documentation
  fix(ci) : conditionally adding pykdtree w/o OpenMP
@ayenpure ayenpure marked this pull request as ready for review October 10, 2024 19:51
Copy link
Collaborator

@johnkit johnkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Abhi. thanks.

@ayenpure ayenpure merged commit 1d2e777 into main Oct 10, 2024
4 checks passed
@ayenpure ayenpure deleted the explorers branch October 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants