Improve the test environment. #264
Open
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, the Girder plugin setup.py file was missing some requirements. The tox file should specify using find-links to fetch large_image wheels. The Dockerfile now more conveniently starts in the directory where the plugin is located. Lastly, there is a test_env.sh script that can be run in the docker to allow girder tests to properly find mongo (unfortunately, girder tests expect mongo to be on localhost, which isn't the case in a docker-compose environment).
|
I'll note that the Dockerfile uses the master branch of large_image, while tox is using the latest published version. |
|
@luciemac I can't remember if you tried this out. We should merge it in if there are no issues with it. |
|
@manthey, I tried it, but could not make it work on my machine. |
|
Bump on this PR. Should we merge? Or is this now obsolete? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the Girder plugin setup.py file was missing some requirements. The tox file should specify using find-links to fetch large_image wheels. The Dockerfile now more conveniently starts in the directory where the plugin is located. Lastly, there is a test_env.sh script that can be run in the docker to allow girder tests to properly find mongo (unfortunately, girder tests expect mongo to be on localhost, which isn't the case in a docker-compose environment).