Migrate plots in the build summary page to d3 #1878
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still a few buggy behaviors that will either need to be fixed on the side of the buildSummary page or in the timeline template itself: * legend width doesn't compute as expected, maybe because the plots are hidden whenever this is computed? * tooltip gets confused if you try to hover on any of the graphs that aren't the first one on the page. but if you hover on the first one and then the others, then it behaves as expected. Something fishy going on with Vue refs? * clicking on a point with a URL in the graph takes you to the respective page as expected, but then if you go "back" using the browser page arrow, the plots in the original page fails to render because the TimelinePlot seems to be getting no data? Vue doesn't pass the props to the child component somehow...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes the component that was recently added in #1826 to convert the build summary page plots from flot to d3. This change marks another step in our efforts to migrate to a single plotting/visualization dependency.