Feature: Adaptive address prefix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch introduces support for a default bech32 address prefix (hrp) queried from the network, and thus specific to each network. Until now, default prefix was hardcoded ('kira'), which was removed in this branch. The new model for the default bech32 prefix was already introduced on Adaptive Default Token feature, which has analogous purpose and was initially intended to implement together. But due to work organization purposes, the Adaptive Bech32 Address Prefix is introduced separately.
List of changes:
- deleted wallet_details.dart which contained hardcoded default bech32 prefix
- created getter "bech32Address" in wallet_address.dart, which extracts the hrp data from QueryTokenAliases or QueryValidators
- created "WalletAddress.fromBech32ValidatorsPage()" to enable viewing addresses in ValidatorsPage when not signed in. Also, changed "bech32Hrp" field to optional, because it is needed only to store the bech32 hrp value in case of using this constructor.
- cleaned up wallet_address.dart - removed not used and invalid methods related to hex. They were created based on wrong assumptions 2 years ago.
- modified tab list controllers, so that each of them requires Wallet Address and uses its getter to get default prefix from Network Module. This change solved bug with broken queries (if network changed, but address in request contained old prefix).
- changed "valoperWalletAddress" to String value "valkey", because wallet should only represent signed in user, and valkey prefix should be fetched from network
- changed order of tests in identity_registrar_cubit_test.dart to properly simulate the process after implementing My Account access block - cannot get IR data without getting bech32 prefix from network
dpajak99
approved these changes
Mar 26, 2024
kronikarz
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces support for a default bech32 address prefix (hrp) queried from the network, and thus specific to each network. Until now, default prefix was hardcoded ('kira'), which was removed in this branch. The new model for the default bech32 prefix was already introduced on Adaptive Default Token feature, which has analogous purpose and was initially intended to implement together. But due to work organization purposes, the Adaptive Bech32 Address Prefix is introduced separately.
List of changes: