Feature: My Account access block #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this branch is to block access to MyAccountPage if the connected network does not contain information about default token or bech32 address prefix. List of changes: - created global_nav_controller.dart to enable navigation without passing an instance of BuildContext - added "leaveProtectedPage()" method from global_nav_controller.dart to "signOut()" method auth_cubit.dart to link those 2 actions - added methods in network_module_bloc.dart with reference to auth_cubit.dart to automatically log out and leave MyAccountPage if user changes to unhealthy network that does not contain TokenDefaultDenomModel - modified sign_in_drawer_page.dart to block connecting the wallet if network does not contain TokenDefaultDenomModel and created sign_in_drawer_warning_section.dart to display "Change network" button and refresh network timer in this case - added NetworkModuleState.refreshing() to provide information about network refreshing to SignInDrawerPage - added "lastRefreshDateTime" to all Network Models (except NetworkEmptyModel) to save info about time of last refresh of each network. This enabled creating a timer in SignInDrawerPage and optimizing network refreshing in network_module_bloc.dart and network_custom_section.cubit.dart. - renamed "timed_refresh_button_cubit.dart" -> "time_counter_cubit.dart" since it was used in sign_in_drawer_warning_section.dart, so it became a generic cubit instead of specific widget centered - removed redundant method from network_module_service.dart and changed nullable TokenDefaultDenomModel to bool variable "valuesFromNetworkExistBool" inside this model - unrelated with the branch's specific domain: added conditions in network_module_bloc.dart and network_custom_section_cubit.dart to prevent still refreshing networks from being refreshed again - unrelated with the branch's specific domain: added TODO about removing IdentityRegistrarCubit initialization in main.dart
dpajak99
approved these changes
Mar 19, 2024
kronikarz
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this branch is to block access to MyAccountPage if the connected network does not contain information about default token or bech32 address prefix.
List of changes: