Bugfix: Transactions signing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous transaction signing system used SIGN_MODE_AMINO_JSON, which is deprecated and no longer supported on the SEKAI side. This branch introduces a new way to sign transactions that use SIGN_MODE_DIRECT mode. List of changes: - imported "cryptography_utils" package which contains crypto-algorithms required to build and sign Cosmos transactions - removed classes from "infra/dto/api_kira/broadcast/request/transaction/components" as they are included in the “cryptography_utils” package and are no longer needed on the miro side - modified classes from "infra/dto/shared/messages" to extend "ProtobufAny" class from "cryptography_utils" package and define protobuf serialization for Cosmos messages - replaced Uint8List private key in wallet.dart with ECPrivateKey from "cryptography_utils" package to simplify accessing private key for transaction signing - removed signature_utils.dart and sign() method from tx_utils.dart, as now signing functionality is handled by the external package - created new sign() method in unsigned_tx_model.dart, which calls proper signing method from "cryptography_utils" package - removed Wallet.fromKeyfileData() constructor from wallet.dart as it wasn't used anywhere but needed improvement after changes - adjusted tests and classes where updated classes were used
nemoforte
approved these changes
Oct 17, 2024
kronikarz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous transaction signing system used SIGN_MODE_AMINO_JSON, which is deprecated and no longer supported on the SEKAI side. This branch introduces a new way to sign transactions that use SIGN_MODE_DIRECT mode.
List of changes: