Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-wrote func defs & doc strings #18

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

re-wrote func defs & doc strings #18

wants to merge 2 commits into from

Conversation

Kinjuriu
Copy link
Owner

Changes

  • Re-wrote main.py with function definition and added doc strings
  • Added collaborative_filtering.py and matrix_factorisation.py to models file

@theycallmejeano
Copy link
Collaborator

Great job on the updates @Kinjuriu
I've made a few comments
You also need to resolve conflicts in main.py
What would I need to run to generate recommendations?

@Kinjuriu
Copy link
Owner Author

Hey @theycallmejeano I have worked on it.

@theycallmejeano
Copy link
Collaborator

Hi @Kinjuriu what do I need to run to generate predictions?

@Kinjuriu
Copy link
Owner Author

Hi @Kinjuriu what do I need to run to generate predictions?

am currently using poetry so..
poetry env info --path // to get the path
source {path_to_venv}/bin/activate to start

to run predictions
poetry run python3 recommender_system/main.py

@theycallmejeano
Copy link
Collaborator

I got another error when running poetry install
There's an open Github issue for this
NicolasHug/Surprise#447

So unfortunately I can't test this. If it works on your end, then that's ok. The only other part to change is here. This should be packages = [{include = "src/recommender_system"}] , which is the path to the folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants