-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MultKAN.py #383
base: master
Are you sure you want to change the base?
Update MultKAN.py #383
Conversation
Fix: call to save_act_in_fit() without required positional argument Fix is for bug: TypeError: MultKAN.recover_save_act_in_fit() missing 1 required positional argument: 'old_save_act' ... kan/MultKan.py:940
Good morning, I found some issues and some possible improvements in the MultKAN library. The MultKAN modulus seems not to be capable to deal with "int values" of mult_arity when multiplication nodes exists. I fixed it by pre-processing the mult_arity vector as follows: if multiplication_bool:
This could be implemented directly into the KAN molulus. Prune() not working properly with MultKAN. Fixed line 1950 as follows: Automatically saving in desired format the tree plot in the function model.plot(). function get_act() not handling different devices. Solved by modifying line 2674: Hope this can help someone having the same issues. |
Fix: call to save_act_in_fit() without required positional argument
Fix is for bug:
TypeError: MultKAN.recover_save_act_in_fit() missing 1 required positional argument: 'old_save_act' ... kan/MultKan.py:940