Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VQT feature, similar to librosa's implementation. TLDR:
gamma
to dampen the Q factor at lower frequencies, while maintaining roughly a constant Q at higher frequencies.Test plan:
plt.imshow
VQT magnitude spectrograms between librosa and nnAudio, overall does not have much difference.There is still some minor value diff between both, mainly due to
lengths
- librosa usesfloat
, but nnAudio usesint
(I keep this implementation so that it is consistent with nnAudio CQT implementation)Added two tests for VQT: (i) at gamma=0, VQT and CQT should be the same; (ii) keep the value diff between librosa and nnAudio within a baseline range (see
tests/test_vqt.py
)Ran both
tests/test_vqt.py
andtests/test_cqt.py
, both passes