Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Interface_DisplayPort lib with PI3DPX1203BZLEX symbol #2337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eclecticc
Copy link
Contributor

@eclecticc eclecticc commented Nov 26, 2019

Create an Interface_DisplayPort library starting with a symbol for Diodes Inc PI3DPX1203BZLEX
https://www.diodes.com/assets/Datasheets/PI3DPX1203B.pdf

The associated footprint is in KiCad/kicad-footprints#1979

Note that the VDD pins are not stacked because Diodes recommends putting a decoupling cap on each one.

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Nov 26, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 28, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 28, 2020
@myfreescalewebpage
Copy link
Collaborator

Hi @eclecticc , thanks for contributing,

A few comments I have during my review:

  • The name of the symbol should be "PI3DPX1203BZL" (discard of temperature, pb free and packaging)
  • SCL should be Input (convention for slave devices in the kicad lib)

Else just need to wait the footprint.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Apr 28, 2020
@myfreescalewebpage
Copy link
Collaborator

@eclecticc ping

@myfreescalewebpage
Copy link
Collaborator

No news of the author, indicate Abandoned

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants