Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added QFN-24-1EP_4x4mm_P0.5mm_EP2.5x2.5mm #2454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Misaka0x2730
Copy link

Added QFN-24 footprint for LAN8742A.
Link to LAN8742A symbol pull request
image


⚠️ Deprecation warning

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@chschlue
Copy link
Contributor

chschlue commented Sep 5, 2020

Please add a link to the corresponding generator PR.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 6, 2020
@cpresser
Copy link
Contributor

cpresser commented Sep 8, 2020

Was this scriped? If yes, please add a link to the script PR.
If not, please head over to https://github.com/pointhi/kicad-footprint-generator and recreate this FP with the generator.

@Misaka0x2730
Copy link
Author

@chschlue @cpresser No, I just edited existing QFN-24-1EP_4x4mm_P0.5mm_EP2.6x2.6mm footprint. Why should I recreate this footprint?

@cpresser
Copy link
Contributor

cpresser commented Sep 8, 2020

There is one reason: Assume at some point in time we want to change the style of all footprints to have rounded corners for the exposed-pad. Or change the Pin1 location to bottom left. Who knows, standards might change.
If we have the definitions for all parts in the generator than that is quite easy to do. Just edit the generator, re-generate all footprints and be done.
If there are manually edited footprints we will also have to manually edit them.

That said, you are right, this is nowhere documented. I will take care of that once we move over to gitlab.

@cpresser cpresser self-assigned this Sep 11, 2020
@cpresser cpresser added Scripting required A scripted version of this contribution is required Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Sep 11, 2020
@myfreescalewebpage
Copy link
Collaborator

@Misaka0x2730 any news of the generator PR ?

@Misaka0x2730
Copy link
Author

@myfreescalewebpage Sorry, now I'm too busy, I'm planning to work on it in next weekends.

@myfreescalewebpage
Copy link
Collaborator

Thanks for the update, keep ongoing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending changes Scripting required A scripted version of this contribution is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants