Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Bosch_LGA-10_2x2mm_P0.275x0.250mm.kicad_mod. #2446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cederom
Copy link
Contributor

@cederom cederom commented Sep 1, 2020

Signed-off-by: Tomasz 'CeDeROM' CEDRO [email protected]

image

Bosch LGA-10 footprint for BMP388 pressure and temperature sensor.


⚠️ Deprecation warning

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Signed-off-by: Tomasz 'CeDeROM' CEDRO <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 1, 2020
@cpresser
Copy link
Contributor

Hello @cederom thanks for you contribution.

I added a screenshot - that really helps a lot to judge how much effort a review is. Thus, it helps to speed up a review.
Same for the datasheet: https://www.mouser.com/pdfdocs/BST-BMP388-DS001-01.pdf#page=48

Here are my first comments (no full review yet)

  • The circle on F.Fab needs to go
  • The Part should be rotated so Pin1 is in the top-left quadrant
  • The bevel on F.Fab should be smaller (25% of package size, so 0.5mm)
  • I don't understand why the silkscreen-corners are asymmetric. Is there a reason for that?
  • The keywords have 11 pin

@cpresser cpresser self-assigned this Sep 15, 2020
@cpresser cpresser added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Sep 15, 2020
@cederom
Copy link
Contributor Author

cederom commented Sep 25, 2020

I have found a kicad footprint generator project already generated a footprint of another LGA based sensor, will update this footprint also with that utlity in a free moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants