-
Notifications
You must be signed in to change notification settings - Fork 712
Add Amphenol G40H11xxxxx 1x1 Mini-SAS HD connector #2048
base: master
Are you sure you want to change the base?
Conversation
d2e6e5e
to
c88f941
Compare
c88f941
to
fc18426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- F7.2: As this is a press fit connector, sticking to the datasheet seems reasonable
- F7.3: Please fix
- F9.3: Please fix
- add RefDes on Fab
- PTH and NPTH dimensions are correct
- Fab, Silk and CrtYd are incorrect
Note that Fab should represent the actual body outline, an Edge.Cuts line can be added additionally.
I'll change it, but, can you explain the rationale for this? |
M1.2 does not invalidate F9.3. In fact, M1.2 is (in technical terminology) utter crap. BTW, this PR also has some wrong dimensions but I'm still working on that. |
Fixed F7.3 and F9.3. I believe there's already RefDes on Fab:
Will address wrong dimensions a bit later. |
3ca58ee
to
2935b39
Compare
Ah, yes, it's hiding behind Silk. Please move inside the Fab outline. |
Add Amphenol G40H11xxxxx 1x1 Mini-SAS HD connector. Once this connector is reviewed, I can add 1x2 and 1x4 variants as well.
Datasheet: https://cdn.amphenol-icc.com/media/wysiwyg/files/drawing/g40h1xxxxhr.pdf
Screenshot:
3D model (proprietary; I will add a README.md with the links once this is merged): https://cdn.amphenol-icc.com/media/wysiwyg/files/3d/sg40h11331hr.zip
3D model holes and pins perfectly match the footprint holes and pads, so I don't think a dimensioned drawing is not necessary here.
Rule violations:
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: