Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Relay: Add Panasonic AD11 Form A #1638

Merged
merged 7 commits into from
Mar 11, 2020

Conversation

antoniovazquezblanco
Copy link
Collaborator

@antoniovazquezblanco antoniovazquezblanco commented Jun 10, 2019

SYM PR: KiCad/kicad-symbols#1915
FP PR: #1638
3D PR: KiCad/kicad-packages3D#572
3D SOURCE PR: easyw/kicad-3d-models-in-freecad#289
KLC NAMING: KiCad/kicad-website#418

https://www.panasonic-electric-works.com/pew/es/downloads/ds_dw_hl_en.pdf

imagen


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jun 10, 2019
@evanshultz
Copy link
Collaborator

  1. Can the description include some basic dimensions?
  2. Can you put pin 1 in the top left corner and unrotate all pads, if needed?
  3. Can you point me to the discussion about relay footprint naming? It's not in KLC but I feel like there was a discussion, only I can't find it now.

Once that's done I'll review. Due to the rotation I don't want to dimension twice.

@antoniovazquezblanco
Copy link
Collaborator Author

Can you point me to the discussion about relay footprint naming? It's not in KLC but I feel like there was a discussion, only I can't find it now.

It is about switches. I would go with the same naming scheme: KiCad/kicad-symbols#580

@antoniovazquezblanco
Copy link
Collaborator Author

TODO: Reopen 3D PR

@evanshultz
Copy link
Collaborator

  1. One thing I don't like about this naming scheme is that it separates members of the same family. For example, if a family have 1FormA and 1FormC members they're potentially spaced apart. Not sure if it's a problem or anybody else feels the same way, but I want to mention it for discussion purposes. Naturally it doesn't apply here so I'll move discussion to the main issue, but rather than start a paradigm that we abandon I'd rather ask before merging and see if there is quick feedback.
  2. Can you unrotate pad 5?
  3. All dimensions look good to me:
    image

@antoniovazquezblanco
Copy link
Collaborator Author

Fixed issues and opened a report to reach an agreement on relay notation.

Thank you very much @evanshultz!

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jun 25, 2019
@evanshultz
Copy link
Collaborator

Oops. I forgot to start the naming discussion. Thanks for stepping in.

If you don't mind, let's allow that to percolate for a bit before merging.

@antoniovazquezblanco
Copy link
Collaborator Author

If you don't mind, let's allow that to percolate for a bit before merging.

Totally agree!

@antoniovazquezblanco antoniovazquezblanco added the Pending KLC issue This depends on a open KLC issue label Jun 25, 2019
@antoniovazquezblanco
Copy link
Collaborator Author

@evanshultz Has naming evolved enough? Can we agree on this or is it still not ready enought?

Thanks!

@antoniovazquezblanco
Copy link
Collaborator Author

@evanshultz what do you think about naming? It seems #1728 has been merged with the current naming convention. Do we agree on moving fordward?

Thanks!

@evanshultz
Copy link
Collaborator

@antoniovazquezblanco
I'm OK with it. Seems like the conversation died off a bit in the thread but the main points are here. Other items can be cleaned up library-wide if and when that happens.

One thing, which oddly CI didn't catch: the 3D model doesn't match the footprint name. Shouldn't it?

@antoniovazquezblanco
Copy link
Collaborator Author

Updated 3D model path!

Updated 3D PR KiCad/kicad-packages3D#663

Thanks!

@antoniovazquezblanco antoniovazquezblanco removed the Pending KLC issue This depends on a open KLC issue label Mar 11, 2020
@evanshultz
Copy link
Collaborator

Thanks!!

@evanshultz evanshultz merged commit e8ac935 into KiCad:master Mar 11, 2020
@antoniovazquezblanco
Copy link
Collaborator Author

Thank you!

@antoniovazquezblanco antoniovazquezblanco deleted the dev/relay branch March 12, 2020 09:36
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants