Merge ancillary libraries into main glslang library and stub originals #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcady-lunarg
approved these changes
Aug 15, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the contents of the existing GenericCodeGen, MachineIndependent, OSDependent, and SPIRV libraries directly into the main glslang library. The original libraries are turned into stubs to be retained for backwards compatibility for a temporary transition period, similar to how the deprecation of the OGLCompiler and HLSL libraries was handled in the past.
The motivation for this change is similar to the motivation for the past deprecation and removal of the OGLCompiler and HLSL libraries. This change will simplify build environments for downstream users by providing them with a "one-stop-shop" glslang static library, and it also lays a foundation for future formal support for a glslang.dll/so dynamic library.