layers: Remove duplicate DescriptorSetLayoutDef compare #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 299927. |
|
CI Vulkan-ValidationLayers build # 17974 running. |
|
CI Vulkan-ValidationLayers build # 17974 failed. |
spencer-lunarg
changed the title
spencer-lunarg
force-pushed
the
spencer-lunarg-compare-source
branch
from
ca3bd0e to
26b4eff
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 300036. |
|
CI Vulkan-ValidationLayers build # 17976 running. |
|
CI Vulkan-ValidationLayers build # 17976 failed. |
arno-lunarg
approved these changes
Nov 12, 2024
| // Compare is in header and static because hash_util KeyValueEqual need the symbol at compile time | ||
| // | ||
| // https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8497 | ||
| // This just checks pointers, but two different VkSampler handles could be created with same createInfo. |
There was a problem hiding this comment.
This part of the comment seems out of place now
arno-lunarg
reviewed
Nov 12, 2024
| return false; | ||
| } | ||
| if (l.pImmutableSamplers) { |
There was a problem hiding this comment.
you still need to check for l.pImmutableSamplers and r.l.pImmutableSamplers to be non null it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2
operator==(const DescriptorSetLayoutDef &lhs, const DescriptorSetLayoutDef &rhs)and removes the one from the header