Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

layers: Check that indirect buffers have the correct usage flag #2334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisforbes
Copy link
Collaborator

Fixes #2333

@chrisforbes
Copy link
Collaborator Author

Formatting issues fixed.

Copy link
Contributor

@daveh-lunarg daveh-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new VU checks look good. Do we need a test to exercise them?

Copy link
Contributor

@tobine tobine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs tests.

Copy link
Contributor

@jzulauf-lunarg jzulauf-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good so far. Assuming you're pushing layer_validation_tests.cpp updates, yes?

@chrisforbes
Copy link
Collaborator Author

Yes, I will add some tests to go with this.

@chrisforbes chrisforbes force-pushed the indirect-buffer-usage branch from 0e13e2e to ee33d96 Compare April 6, 2018 22:18
@mark-lunarg
Copy link
Collaborator

@chrisforbes, this repository will close for write access on Sunday, 5/13/2018. If it is pushed before that time it will be present in the follow-on Vulkan-ValidationLayers repository on Monday, otherwise a new PR will be required in the new repo. (I think it's acceptable to push the changes if they're OK and to add the tests next week).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants