This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
add the Vector16 capability for both vec8 and vec16 types #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
approved these changes
Feb 28, 2018
|
Good idea - I added a regression test for this case. |
AlexeySotkin
pushed a commit
to AlexeySotkin/SPIRV-LLVM
that referenced
this pull request
Mar 12, 2018
…up#229) * add the Vector16 capability for both vec8 and vec16 types * added test to verify Vector16 capability is added for vectors with eight elements
AlexeySotkin
pushed a commit
to AlexeySotkin/SPIRV-LLVM
that referenced
this pull request
Apr 3, 2018
…up#229) * add the Vector16 capability for both vec8 and vec16 types * added test to verify Vector16 capability is added for vectors with eight elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #228. Even though the name of the capability is Vector16, it needs to be added for both vectors or 8 elements and vectors of 16 elements.
CC: @bader