Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split headers, etc. #26

Merged
merged 119 commits into from
Apr 14, 2021
Merged

Split headers, etc. #26

merged 119 commits into from
Apr 14, 2021

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Dec 21, 2020

This is a work in progress but nearly done.

Current state: produces these headers:
openxr.zip

cc @matthieucoquet - I incorporated some of your suggestions in here.

@rpavlik
Copy link
Contributor Author

rpavlik commented Jan 8, 2021

OK, this is a fairly substantial update, and really makes things better I think. Things are split into individual files to reduce include overhead and let people use e.g. the dispatch without too much else (the dispatch headers are actually entirely independent now), orthogonality is improved, doxygen is much better, usability bits smoothed out (I ported hello_xr and another project), etc.

Here are the generated headers:
openxr.zip

Here are the doxygen docs:
html.zip

@rpavlik rpavlik marked this pull request as ready for review January 8, 2021 23:40
@matthieucoquet
Copy link

I tried the headers (with some small changes related to what I mention in #27) and everything works well in my small app.

I just had to download the latest PowerShell to generate the headers. The version by default in Windows results in unclear errors. Maybe it should be mention in the Readme.

The macro to default the dispatcher are pretty nice.

@rpavlik
Copy link
Contributor Author

rpavlik commented Jan 11, 2021

Great, thanks for the review! I'll make a note in the README

@rpavlik
Copy link
Contributor Author

rpavlik commented Jan 11, 2021

I actually was able to just modify the script slightly so it works with the standard powershell in Windows 10 :)

@rpavlik
Copy link
Contributor Author

rpavlik commented Jan 12, 2021

OK, this has been updated slightly. (Main changes are fixing a flags bug, and doing a better job with Bool32.)

Also, for your review pleasure, I have ported hello_xr to the current state of this repo: https://github.com/rpavlik/hello_xr_hpp/tree/pr26-210112

Each commit is buildable so you can see the process I used.

@rpavlik rpavlik merged commit 1c815f6 into master Apr 14, 2021
@rpavlik rpavlik deleted the split-headers branch April 14, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants