Add properties parameter to all command-buffer commands #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
added
the
cl_khr_command_buffer
bashbaug
reviewed
Aug 8, 2024
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Aug 14, 2024
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215 to address KhronosGroup/OpenCL-Docs#1207 A new `cl_command_properties_khr` properties parameter is added to all command recording entry-points, and the patch version is bumped.
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Aug 15, 2024
Update cl_khr_command_buffer API to match breaking change from KhronosGroup/OpenCL-Docs#1215
|
Merging after final review, as discussed in the September 3rd teleconference. |
kpet
approved these changes
Sep 3, 2024
bashbaug
approved these changes
Sep 4, 2024
See Issue KhronosGroup#1207 disucssion how it could make the `cl_khr_command_buffer` extension more extensible if we allowed all the command-recording parameters to have a `properties` parameter that could be used.
EwanC
force-pushed
the
ewan/command_properties
branch
from
3a3d14e
to
65907ff
Compare
EwanC
added a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Sep 5, 2024
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Sep 5, 2024
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215 to address KhronosGroup/OpenCL-Docs#1207 A new `cl_command_properties_khr` properties parameter is added to all command recording entry-points, and the patch version is bumped.
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Sep 5, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
|
Merging as discussed in the September 3rd teleconference + email. |
bashbaug
added a commit
to KhronosGroup/OpenCL-Headers
that referenced
this pull request
Sep 6, 2024
* Add properties parameter to all command-buffer commands Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215 to address KhronosGroup/OpenCL-Docs#1207 A new `cl_command_properties_khr` properties parameter is added to all command recording entry-points, and the patch version is bumped. * Rename CL_MUTABLE_COMMAND_PROPERTIES_ARRAY_KHR --------- Co-authored-by: Ben Ashbaugh <[email protected]>
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CLHPP
that referenced
this pull request
Sep 6, 2024
* Add properties parameter to all command-buffer commands Updates to compile with header change KhronosGroup/OpenCL-Headers#260 * Update to reflect CL_MUTABLE_COMMAND_PROPERTIES_ARRAY_KHR See KhronosGroup/OpenCL-Docs#1215 (comment)
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #1207 discussion how it could make the
cl_khr_command_bufferextension more extensible if we allowed all the command-recording parameters to have apropertiesparameter that could be used.Closes #1207
Related PRs: