-
Notifications
You must be signed in to change notification settings - Fork 91
Arguments parsing implementation #34
base: master
Are you sure you want to change the base?
Conversation
Parsed only when allow_arguments is set
@zeit/ncc is deprecated
This would be a great feature to add. |
hey @shpingalet007 can you publish on github marketplace as shanegenschaw did here? #46 ? |
@eliasmelgaco I could do it, but wouldn't it be better if shanegenschaw merges my PR? There are already 5 modules (original + 4 forks) published on GitHub Actions Marketplace. I would recommend the community to select his repository as main fork while patches are not accepted in the original one. He already has 3 stars on his repo and looks like the most active fork. Cheers |
Hey, @shpingalet007 and @eliasmelgaco, I have a PR ready to pull this into my fork, please take a look/give a trial, and let me know if it looks good: If it looks okay, I'll merge and tag it as |
@shpingalet007 @shanegenschaw for me your PRs are perfect. I would love to use both changes in the Khan project (main project) |
@eliasmelgaco okay, my PR was merged on shanegenschaw/pull-request-comment-trigger. Feel free to leave your feedback here, 🙂 I will use the opportunity to fix any found issues on this PR and push updates to the fork 👍 |
The work from @shpingalet007 has been merged and published as |
@shanegenschaw I removed |
Trigger in middle of comment works very unstable. Removing prefixOnly and related functionality
2b8837e
to
8963ccd
Compare
@shpingalet007 I've merged your commit into a new branch/PR, if you think it looks good: shanegenschaw#6 |
Changes
allow_arguments: Boolean
. It enables/disables arguments parsing. It is set tofalse
by default.**
in trigger and considers the marked part of the comment as argument. Output to thesteps.check.outputs.arguments
. It doesn't do anything ifallow_arguments: false
.#deploy on ** environment
comment.Other changes
@zeit/ncc
to@vercel/ncc
as it was deprecated.Readme.md
.