Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Arguments parsing implementation #34

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shpingalet007
Copy link

@shpingalet007 shpingalet007 commented Oct 4, 2022

Changes

  1. Added GitHub Actions input - allow_arguments: Boolean. It enables/disables arguments parsing. It is set to false by default.
  2. Arguments parsing via double-asterisk marker - script looks for ** in trigger and considers the marked part of the comment as argument. Output to the steps.check.outputs.arguments. It doesn't do anything if allow_arguments: false.
  3. Add new example - add job that enables debugging #deploy on ** environment comment.

Other changes

  • Replace npm @zeit/ncc to @vercel/ncc as it was deprecated.
  • Upload new action NCC build.
  • Documented everything in Readme.md.

@mattkeeler
Copy link

This would be a great feature to add.

@eliasmelgaco
Copy link

eliasmelgaco commented May 25, 2023

hey @shpingalet007 can you publish on github marketplace as shanegenschaw did here? #46 ?

@shpingalet007
Copy link
Author

@eliasmelgaco I could do it, but wouldn't it be better if shanegenschaw merges my PR? There are already 5 modules (original + 4 forks) published on GitHub Actions Marketplace. I would recommend the community to select his repository as main fork while patches are not accepted in the original one. He already has 3 stars on his repo and looks like the most active fork. Cheers

@shanegenschaw
Copy link

Hey, @shpingalet007 and @eliasmelgaco, I have a PR ready to pull this into my fork, please take a look/give a trial, and let me know if it looks good:

If it looks okay, I'll merge and tag it as v2 and v2.1.0

@eliasmelgaco
Copy link

@shpingalet007 @shanegenschaw for me your PRs are perfect. I would love to use both changes in the Khan project (main project)

@shpingalet007
Copy link
Author

@eliasmelgaco okay, my PR was merged on shanegenschaw/pull-request-comment-trigger. Feel free to leave your feedback here, 🙂 I will use the opportunity to fix any found issues on this PR and push updates to the fork 👍

@shanegenschaw
Copy link

shanegenschaw commented May 26, 2023

The work from @shpingalet007 has been merged and published as v2 and v2.1.0

@shpingalet007
Copy link
Author

@shanegenschaw I removed prefixOnly flag. It is very unstable and difficult to make it so. Updated the PR, you can update your fork too if you want to.

Trigger in middle of comment works very unstable. Removing prefixOnly and related functionality
@shanegenschaw
Copy link

shanegenschaw commented Aug 7, 2023

@shanegenschaw I removed prefixOnly flag. It is very unstable and difficult to make it so. Updated the PR, you can update your fork too if you want to.

@shpingalet007 I've merged your commit into a new branch/PR, if you think it looks good: shanegenschaw#6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants