revision for lesson 3 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinb-khan
force-pushed
the
revise-lesson-2
branch
from
f19f370
to
b0d1cbd
Compare
kevinb-khan
force-pushed
the
revise-lesson-3
branch
from
3c0ad4c
to
66362a2
Compare
kevinb-khan
force-pushed
the
revise-lesson-2
branch
from
b0d1cbd
to
e5a43dc
Compare
kevinb-khan
force-pushed
the
revise-lesson-3
branch
from
66362a2
to
12b6808
Compare
kevinb-khan
force-pushed
the
revise-lesson-3
branch
from
12b6808
to
0a308ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make revisions to lesson 3 based on feedback. I'm punting on providing more details around mocking singletons until next week. I'm hoping to get some feedback from people on the post on made in #js-testing on the matter.
Issue: None
Test plan: