Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added discord.com to regex. #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added discord.com to regex. #116

wants to merge 1 commit into from

Conversation

2M4U
Copy link

@2M4U 2M4U commented Oct 25, 2020

PULL REQUEST

Overview

PR description/overview (changes introduced, implementation justification if needed, enhancement this PR brings...).

Status

  • Typings have been updated or don't need to be.
  • [ * ] This PR have been tested and is ready to be merged.

Semantic versioning classification

  • MAJOR: This PR introduces BREAKING changes (direct API change).
  • [ * ] MINOR: This PR adds new features, improve the code and/or implies minimal API changes.
  • PATCH: This PR fixes a bug, if needed it also references the relevant issue or documentation.
  • PATCH: This PR improve performance or code refactor without API changes.
  • PATCH: This PR only includes non-code changes (documentation, style, CI, tools...).

@Khaaz
Copy link
Owner

Khaaz commented Oct 25, 2020

If you really want to change the examples, you should also change the eris example.
Also since discord entirely switched to discord.com, you can entirely change discordapp to discord instead of adding it.

@Khaaz Khaaz changed the base branch from master to dev October 25, 2020 12:12
@Khaaz Khaaz changed the base branch from dev to master October 25, 2020 12:12
@Khaaz
Copy link
Owner

Khaaz commented Oct 25, 2020

Also please, do this PR FROM the dev branch TO the dev branch.

@2M4U
Copy link
Author

2M4U commented Oct 29, 2020

Not entirely sure on how to do so; I'm not really a regular github user, some of github is new to me.

Also please, do this PR FROM the dev branch TO the dev branch.

@Khaaz
Copy link
Owner

Khaaz commented Oct 30, 2020

I guess here you don't have any other choice than just closing and reopening.
work on the dev branch on your fork, and open a PR from your dev branch targetting this repo dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants