Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added V5 Max ISO #298

Closed

Conversation

susch19
Copy link

@susch19 susch19 commented Aug 23, 2024

Description

Add the v5 max ISO firmware files. The implementation is based on the v3 max ISO to ANSI differences, so I don't know if all the values are correct, but for now all keys are working when testing matrix on launcher.keychron.com. It's also still detected as the ISO knob version.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Mhilkos
Copy link

Mhilkos commented Aug 26, 2024

The firmware is available as a pre-compile on the keychron website. https://www.keychron.com/pages/firmware-and-json-files-of-the-keychron-qmk-v-and-v-max-series-keyboards
Also, theres VIA json there for download if you scroll down so you can make VIA detect it if you dont want to use the keychron launcher.

@susch19
Copy link
Author

susch19 commented Aug 26, 2024

The firmware is available as a pre-compile on the keychron website. https://www.keychron.com/pages/firmware-and-json-files-of-the-keychron-qmk-v-and-v-max-series-keyboards

Yeah, but I didn't add the file, but the source code for it, so one can customize it. I guess keychron will most likely add their own source code version later on, but as long as this didn't happen, it is good to have the source code. But you are right, i didn't think to download the via json from the website, so i can at least use the correct via json in this pr

* use the version that is provided on the keychron website instead of my own
@susch19
Copy link
Author

susch19 commented Aug 29, 2024

The layout has been added, so this pr is not needed anymore

@susch19 susch19 closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants