Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keychron k17 pro #184

Conversation

KeychronMacro
Copy link
Member

As the title and request for a review, thanks!

Description

  • Added k17_pro/ansi_encoder rgb and white version
  • Added q10_pro/ansi_encoder and q10_pro/iso_encoder
  • Added q13_pro/ansi_encoder and q13_pro/iso_encoder

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Mchh85
Copy link

Mchh85 commented Oct 23, 2023

@keychron-dev @lokher 您好,我买的q13 pro 已经到手了,我需要修改固件。什么时候在bluetooth_playground分支中合并这个啊?已经买了五天了,一直没有这个型号。

@lokher
Copy link
Member

lokher commented Oct 23, 2023

@keychron-dev @lokher 您好,我买的q13 pro 已经到手了,我需要修改固件。什么时候在bluetooth_playground分支中合并这个啊?已经买了五天了,一直没有这个型号。

我们最近比较忙,要晚点才能处理,你可以直接从以下分支把代码提取出来放到 bluetooth_playgroun 中编译
https://github.com/lalalademaxiya1/qmk_firmware/tree/keychron_k17_pro

keyboards/keychron/bluetooth/bluetooth.c Outdated Show resolved Hide resolved
keyboards/keychron/k17_pro/k17_pro.h Outdated Show resolved Hide resolved
keyboards/keychron/q10_pro/ansi_encoder/ansi_encoder.c Outdated Show resolved Hide resolved
keyboards/keychron/q10_pro/ansi_encoder/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q10_pro/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q10_pro/iso_encoder/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q10_pro/iso_encoder/iso_encoder.c Outdated Show resolved Hide resolved
keyboards/keychron/q13_pro/ansi_encoder/ansi_encoder.c Outdated Show resolved Hide resolved
keyboards/keychron/q13_pro/iso_encoder/iso_encoder.c Outdated Show resolved Hide resolved
@lokher lokher mentioned this pull request Nov 10, 2023
… to multiplexed backlight LED. 2:Fix the issue of no button release during low power shutdown. 3:The maximum current of backlight white light is too high at 110mA
@campbellhennessy
Copy link

Hello, I am wondering when this PR is planned to be merged into the bluetooth_playground branch?

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Jan 22, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Feb 22, 2024
@JSelvaraj JSelvaraj mentioned this pull request Jul 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants