Added rowIndex to colParser function #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds another parameter to the custom colParser function callback that exposes the row index being processed. Zero-based. Adds an assert to an existing test to provide coverage. The unit test for this was not executing correctly, so no assertions would fail under any conditions. I refactored the test to use async/await instead of done() and the test started working as expected. Issue Keyang#373
Pull Request Test Coverage Report for Build 243
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another parameter to the custom colParser function callback
that exposes the row index being processed. Zero-based. Adds an
assert to an existing test to provide coverage.
The unit test for this was not executing correctly, so no assertions
would fail under any conditions. I refactored the test to use
async/await instead of done() and the test started working as
expected.
Issue #373