Generic policy status reconciler #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioifg94
commented
Dec 6, 2023
| type ServiceProbeResult struct { | ||
| } | ||
|
|
||
| func (r *PolicyReconciler[T]) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { |
There was a problem hiding this comment.
This is the generic Reconcile function that delegates the validation, reconciliation, and service probing and contains the common logic to update the status based on the result of these operations
sergioifg94
commented
Dec 6, 2023
| return &p.Status.Conditions | ||
| } | ||
|
|
||
| type DummyPolicyReconciler struct { |
There was a problem hiding this comment.
An example of how a reconciler would look like using the generic policy reconciler
sergioifg94
commented
Dec 6, 2023
Comment on lines
+43
to
+46
| var relatedResource client.Object | ||
| r.client.Get(ctx, types.NamespacedName{ | ||
| Name: "dummy", | ||
| }, relatedResource) |
There was a problem hiding this comment.
Doesn't actually do anything, this is just to prove that it is possible within the different stages to use the fields from the inner target ref reconciler
KevFan
force-pushed
the
rlp-policy-status
branch
6 times, most recently
from
5863b25 to
ba26ec2
Compare
KevFan
force-pushed
the
rlp-policy-status
branch
2 times, most recently
from
64b8232 to
6874ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC of an experimental approach to a generic policy reconciler that sets the status using a template method pattern