-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cotrend Tutorial #137
base: master
Are you sure you want to change the base?
Conversation
Is it ready for review? |
@barentsen Yes please, it's a bit rough and I'm not sure it's what you wanted...? Early comments are much appreciated! :D Easier to read here. |
Maybe this is going to be helpful to include in this tutorial? |
@@ -0,0 +1,181 @@ | |||
|
|||
Example 5: Fitting CBVs to Remove Long Term Trends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GO style is to avoid capitalizing titles, i.e. "remove long term trends" instead of "Remove Long Term Trends".
Example 5: Fitting CBVs to Remove Long Term Trends | ||
================================================== | ||
|
||
What are CBVs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a queston mark?
curves. They are built from the most common trends observed in each | ||
channel. You can read more about CBVs in `Demystifying Kepler | ||
Data <https://arxiv.org/pdf/1207.3093.pdf>`__. They can be used to clean | ||
lightcurves of common trends experience by all targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explain CBVs in a lot more detail here. Let's borrow content from Sections 4.2 and 5 of the "Demystifying Kepler Data" (it is fine to copy verbatim from that paper).
Thanks for working on this! My main comments are:
|
Yep, let's just use the Also, perhaps would be more useful to use the recently added |
|
Added a tutorial for CBVs on Tabby's star. It's pretty brief, maybe that's a good thing?