Feat/zapier project description #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Kentico.Xperience.Zapier/Admin/UIPages/ZapierNewApiKeyPage.cs
Outdated
Show resolved
Hide resolved
|
Assuming this PR updates the repo to be fully supported (instead of a Lab, as mentioned in the docs Changelog), we'll also want to update the following
|
|
I have made the required adjustments. |
src/Kentico.Xperience.Zapier/Admin/InfoModels/ApiKeyInfoProvider.cs
Outdated
Show resolved
Hide resolved
|
Was there any reason for Zapier to target .Net 8.0? XbK targets .Net 6 and we should ideally target all integrations to the same version so that customers are not forced to upgrade entire projects to .Net 8 because of them. |
michalJakubis
approved these changes
Apr 25, 2024
@michalJakubis This comes from our announced .NET 6 support guidance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version reflects changes required by Project description word document.
As well as new nuget, Zap CLI application has to be pushed and published for zapier review
There are breaking changes, as we need to follow best practices document. I think that is not going to be a problem as the old version is preview version.