Handle new data type #34
DanielJurcaBSAnnotations
11 warnings
|
Build and Test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build and Test:
examples/DancingGoat/Models/ContentRepositoryBase.cs#L30
XML comment has a param tag for 'pageRetriever', but there is no parameter by that name
|
|
Build and Test:
examples/DancingGoat/DataProtectionSamples/PersonalDataCollectors/SampleContactDataCollectorCore.cs#L121
Private classes which are not derived in the current assembly should be marked as 'sealed'. (https://rules.sonarsource.com/csharp/RSPEC-3260)
|
|
Build and Test:
examples/DancingGoat/DataProtectionSamples/PersonalDataCollectors/SampleContactDataCollectorCore.cs#L420
All 'WriteConsents' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136)
|
|
Build and Test:
examples/DancingGoat/Resources/SharedResources.cs#L3
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
|
|
Build and Test:
examples/DancingGoat/Components/Widgets/CTAButton/CTAButtonWidgetProperties.cs#L11
Rename class 'CTAButtonWidgetProperties' to match pascal case naming rules, consider using 'CtaButtonWidgetProperties'. (https://rules.sonarsource.com/csharp/RSPEC-101)
|
|
Build and Test:
examples/DancingGoat/Components/Widgets/CTAButton/CTAButtonWidgetViewModel.cs#L6
Rename class 'CTAButtonWidgetViewModel' to match pascal case naming rules, consider using 'CtaButtonWidgetViewModel'. (https://rules.sonarsource.com/csharp/RSPEC-101)
|
|
Build and Test:
examples/DancingGoat/DataProtectionSamples/PersonalDataCollectors/Writers/HumanReadablePersonalDataWriter.cs#L179
Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (https://rules.sonarsource.com/csharp/RSPEC-1186)
|
|
Build and Test:
examples/DancingGoat/Helpers/TagHelpers/LanguageLinkTagHelper.cs#L85
Loop should be simplified by calling Select(queryParam => queryParam.Key)) (https://rules.sonarsource.com/csharp/RSPEC-3267)
|
|
Build and Test:
examples/DancingGoat/Models/ContentRepositoryBase.cs#L35
Change the visibility of this constructor to 'protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)
|
|
Build and Test:
examples/DancingGoat/Helpers/AreaRestrictionHelper.cs#L22
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
|