Treat empty audience as equivalent to no audience #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There's a specific case where audience is supplied but empty, which I think should be treated as the same as audience not being supplied.
Ie:
Will fail validation if
options.aud
isNone
.While (no aud)
passes validation in that same case where
options.aud
isNone
.The user could just turn off audience validation, but the default is audience validation on, which is reasonable, but then it should accept the supplied but empty audience.
This could also be fixed by changing the deserialization, an empty vec gets deserialized into
Multiple
but it could be deserialized intoNotPresent
, but that is a bit trickier.